-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ci #1960
fix ci #1960
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1960 +/- ##
=====================================
Coverage 74.9% 74.9%
=====================================
Files 122 122
Lines 20375 20375
=====================================
Hits 15277 15277
Misses 5098 5098 ☔ View full report in Codecov by Sentry. |
@@ -1,4 +1,5 @@ | |||
mod rate_limit; | |||
#[allow(dead_code)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -42,7 +42,7 @@ temp-env = "0.3.6" | |||
thiserror = { version = "1", default-features = false } | |||
tonic = { version = "0.12", default-features = false } | |||
tonic-build = "0.12" | |||
tokio = { version = "1", default-features = false } | |||
tokio = { version = "~1.38.0", default-features = false } #1.39 needs msrv bump to rustc 1.70 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trying to avoid being aggressive in msrv
bump from 1.65
to 1.70
, so pinning tokio
version < 1.39
. tracing is still on 1.63
so good to be close to it. Unless there are other thoughts :)
Fixes #1959
Design discussion issue (if applicable) #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes