Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ci #1960

Merged
merged 3 commits into from
Jul 23, 2024
Merged

fix ci #1960

merged 3 commits into from
Jul 23, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Jul 23, 2024

Fixes #1959
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.9%. Comparing base (406e31b) to head (b201384).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1960   +/-   ##
=====================================
  Coverage   74.9%   74.9%           
=====================================
  Files        122     122           
  Lines      20375   20375           
=====================================
  Hits       15277   15277           
  Misses      5098    5098           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -1,4 +1,5 @@
mod rate_limit;
#[allow(dead_code)]
Copy link
Member Author

@lalitb lalitb Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like new beta rust toolchain (1.81.x) is more strict towards unused code. Also since failing file remote.rs is generated from proto file so not modifying it. Instead making whole generated file to allow dead-code.

@lalitb lalitb marked this pull request as ready for review July 23, 2024 19:20
@lalitb lalitb requested a review from a team July 23, 2024 19:20
@@ -42,7 +42,7 @@ temp-env = "0.3.6"
thiserror = { version = "1", default-features = false }
tonic = { version = "0.12", default-features = false }
tonic-build = "0.12"
tokio = { version = "1", default-features = false }
tokio = { version = "~1.38.0", default-features = false } #1.39 needs msrv bump to rustc 1.70
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying to avoid being aggressive in msrv bump from 1.65 to 1.70, so pinning tokio version < 1.39. tracing is still on 1.63 so good to be close to it. Unless there are other thoughts :)

@cijothomas cijothomas merged commit 57bcd59 into open-telemetry:main Jul 23, 2024
25 checks passed
@lalitb lalitb deleted the fix-ci-2 branch July 27, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failure [msrv and beta]
3 participants