fix ci #1960
Merged
fix ci #1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1960 +/- ##
=====================================
Coverage 74.9% 74.9%
=====================================
Files 122 122
Lines 20375 20375
=====================================
Hits 15277 15277
Misses 5098 5098 ☔ View full report in Codecov by Sentry. |
lalitb
commented
Jul 23, 2024
| @@ -1,4 +1,5 @@ | |||
| mod rate_limit; | |||
| #[allow(dead_code)] | |||
lalitb
commented
Jul 23, 2024
| @@ -42,7 +42,7 @@ temp-env = "0.3.6" | |||
| thiserror = { version = "1", default-features = false } | |||
| tonic = { version = "0.12", default-features = false } | |||
| tonic-build = "0.12" | |||
| tokio = { version = "1", default-features = false } | |||
| tokio = { version = "~1.38.0", default-features = false } #1.39 needs msrv bump to rustc 1.70 | |||
There was a problem hiding this comment.
trying to avoid being aggressive in msrv bump from 1.65 to 1.70, so pinning tokio version < 1.39. tracing is still on 1.63 so good to be close to it. Unless there are other thoughts :)
utpilla
approved these changes
Jul 23, 2024
cijothomas
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1959
Design discussion issue (if applicable) #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes