Fix PartialEq for Value in opentelemetry-stdout #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PartialEq's previous implementation called back to itself with the same arguments. Here we extract the underlying value and compare them. If the enum types are different, it returns false.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1955 +/- ##
=======================================
- Coverage 74.9% 74.9% -0.1%
=======================================
Files 122 122
Lines 20375 20387 +12
=======================================
Hits 15276 15276
- Misses 5099 5111 +12 ☔ View full report in Codecov by Sentry. |
utpilla
reviewed
Jul 23, 2024
| (Value::Array(a), Value::Array(oa)) => a.eq(oa), | ||
| (Value::KeyValues(kv), Value::KeyValues(okv)) => kv.eq(okv), | ||
| (Value::BytesValue(b), Value::BytesValue(ob)) => b.eq(ob), | ||
| (Value::Bool(_), _) => false, |
There was a problem hiding this comment.
Use a simpler wild card pattern instead?
_ => false,There was a problem hiding this comment.
My concern was that if a new variant were added to Value, PartialEq would compile but have an incorrect result. With this version, there would be a compile error. But if you favor conciseness, I can change.
lalitb
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1952
Changes
PartialEq's previous implementation could call itself again with the same arguments. Here the underlying values are extracted and compared. If the enum types are different, false is returned.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes