Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zstd compression for tonic exporter #1947

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

harscoet
Copy link
Contributor

@harscoet harscoet commented Jul 19, 2024

Changes

Zstd compression can be used with tonic https://docs.rs/tonic/0.12.1/tonic/codec/enum.CompressionEncoding.html#variant.Zstd

It is the recommended compression algorithm for NewRelic https://docs.newrelic.com/docs/opentelemetry/best-practices/opentelemetry-otlp/

Additionally, you should enable compression to reduce payload size and limit the likelihood of encountering payload size limits. New Relic supports gzip and zstd compression. zstd compression is higher performance and recommended if your exporter supports it. See compression comparison for more details on benchmark information.

As this requires a feature, I changed the error message for FeatureRequiredForCompressionAlgorithm to have a more detailed error

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@harscoet harscoet requested a review from a team July 19, 2024 13:10
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.9%. Comparing base (a1f02fa) to head (3d496e7).

Files Patch % Lines
opentelemetry-otlp/src/exporter/mod.rs 0.0% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1947   +/-   ##
=====================================
  Coverage   74.9%   74.9%           
=====================================
  Files        122     122           
  Lines      20370   20375    +5     
=====================================
+ Hits       15273   15277    +4     
- Misses      5097    5098    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a changelog entry.

@lalitb lalitb merged commit 406e31b into open-telemetry:main Jul 23, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants