Fix Stress Test #1935
Merged
Fix Stress Test #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1935 +/- ##
=====================================
Coverage 74.9% 74.9%
=====================================
Files 122 122
Lines 20311 20311
=====================================
Hits 15217 15217
Misses 5094 5094 ☔ View full report in Codecov by Sentry. |
|
Can you update results, if they are different as well? |
lalitb
reviewed
Jul 15, 2024
ThomsonTan
reviewed
Jul 15, 2024
lalitb
approved these changes
Jul 15, 2024
cijothomas
reviewed
Jul 16, 2024
| RAM: 64.0 GB | ||
| 69 M/sec | ||
| ~31 M/sec |
There was a problem hiding this comment.
I am seeing different numbers with the AMD hardware! (its exactly half of the current in all cases).
Maybe, stick with same hardware which @lalitb and myself has , so the numbers are comparable easily.
cijothomas
reviewed
Jul 16, 2024
| RAM: 64.0 GB | ||
| 35 M /sec | ||
| ~9.5 M /sec |
cijothomas
reviewed
Jul 16, 2024
| RAM: 64.0 GB | ||
| 4.6M /sec | ||
| ~1.8 M/sec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Here's a comparison of the stress test results: