Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Stress Test #1935

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Jul 15, 2024

Changes

  • Fixed the Stress to not double count throughput

Here's a comparison of the stress test results:

Test main branch Current PR
Logs 62,050,400 iterations/sec 31,245,400 iterations/sec
Metrics 19,652,600 iterations/sec 9,550,400 iterations/sec
Traces 13,256,000 iterations/sec 6,496,600 iterations/sec

@utpilla utpilla requested a review from a team July 15, 2024 16:24
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.9%. Comparing base (5922205) to head (b10bb79).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1935   +/-   ##
=====================================
  Coverage   74.9%   74.9%           
=====================================
  Files        122     122           
  Lines      20311   20311           
=====================================
  Hits       15217   15217           
  Misses      5094    5094           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas
Copy link
Member

Can you update results, if they are different as well?

RAM: 64.0 GB
69 M/sec
~31 M/sec
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am seeing different numbers with the AMD hardware! (its exactly half of the current in all cases).

Maybe, stick with same hardware which @lalitb and myself has , so the numbers are comparable easily.

RAM: 64.0 GB
35 M /sec
~9.5 M /sec
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~17 in AMD

RAM: 64.0 GB
4.6M /sec
~1.8 M/sec
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~3 in AMD

@cijothomas cijothomas merged commit 47e52f1 into open-telemetry:main Jul 16, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants