Improve multi-threaded test for Counter #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utpilla
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1858 +/- ##
=====================================
Coverage 74.5% 74.5%
=====================================
Files 122 122
Lines 19809 19859 +50
=====================================
+ Hits 14760 14808 +48
- Misses 5049 5051 +2 ☔ View full report in Codecov by Sentry. |
TommyCpp
reviewed
Jun 4, 2024
…om/utpilla/opentelemetry-rust into Update-counter-multithreaded-tests
cijothomas
reviewed
Jun 4, 2024
cijothomas
reviewed
Jun 4, 2024
| for i in 0..10 { | ||
| thread::scope(|s| { | ||
| s.spawn(|| { | ||
| counter.add(1, &[KeyValue::new("key1", "value1")]); |
There was a problem hiding this comment.
add 1-3 diff. timeseries
add 1 with 0 attributes.
There was a problem hiding this comment.
and a separate test for overflow part.
cijothomas
reviewed
Jun 4, 2024
|
|
||
| for thread in update_threads { | ||
| thread.join().unwrap(); | ||
| for i in 0..10 { |
There was a problem hiding this comment.
nit: maybe use 2x number of cores in the machine?
cijothomas
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1845
Changes