Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify loggerprovider shutdown, flush to return single Result and handle repeat shutdown calls #1750

Merged

reverts

1ebba36
Select commit
Loading
Failed to load commit list.
Merged

Modify loggerprovider shutdown, flush to return single Result and handle repeat shutdown calls #1750

reverts
1ebba36
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 13, 2024 in 0s

71.6% (+0.5%) compared to 348ec9e

View this Pull Request on Codecov

71.6% (+0.5%) compared to 348ec9e

Details

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 71.6%. Comparing base (348ec9e) to head (1ebba36).
Report is 23 commits behind head on main.

❗ Current head 1ebba36 differs from pull request most recent head f96e66a. Consider uploading reports for the commit f96e66a to get more accurate results

Files Patch % Lines
opentelemetry-sdk/src/logs/log_emitter.rs 92.8% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1750     +/-   ##
=======================================
+ Coverage   71.0%   71.6%   +0.5%     
=======================================
  Files        135     136      +1     
  Lines      20751   20845     +94     
=======================================
+ Hits       14746   14934    +188     
+ Misses      6005    5911     -94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.