Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance LogRecord::add_attributes interface to accept generic Iterables #1741

Merged
merged 6 commits into from
May 11, 2024

make test validation concise

397905a
Select commit
Loading
Failed to load commit list.
Merged

Enhance LogRecord::add_attributes interface to accept generic Iterables #1741

make test validation concise
397905a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 11, 2024 in 0s

71.4% (+0.3%) compared to 348ec9e

View this Pull Request on Codecov

71.4% (+0.3%) compared to 348ec9e

Details

Codecov Report

Attention: Patch coverage is 84.78261% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 71.4%. Comparing base (348ec9e) to head (397905a).
Report is 15 commits behind head on main.

❗ Current head 397905a differs from pull request most recent head 1f33277. Consider uploading reports for the commit 1f33277 to get more accurate results

Files Patch % Lines
opentelemetry/src/logs/noop.rs 0.0% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1741     +/-   ##
=======================================
+ Coverage   71.0%   71.4%   +0.3%     
=======================================
  Files        135     136      +1     
  Lines      20751   20880    +129     
=======================================
+ Hits       14746   14912    +166     
+ Misses      6005    5968     -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.