Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Metrics tests and add more #1737

Merged

Merge branch 'main' into cijothomas/metric-test-refacotr

ef23883
Select commit
Loading
Failed to load commit list.
Merged

Refactor Metrics tests and add more #1737

Merge branch 'main' into cijothomas/metric-test-refacotr
ef23883
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 12, 2024 in 1s

71.5% (+0.5%) compared to 348ec9e

View this Pull Request on Codecov

71.5% (+0.5%) compared to 348ec9e

Details

Codecov Report

Attention: Patch coverage is 88.95706% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 71.5%. Comparing base (348ec9e) to head (ef23883).
Report is 17 commits behind head on main.

Files Patch % Lines
opentelemetry-sdk/src/metrics/mod.rs 88.9% 18 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1737     +/-   ##
=======================================
+ Coverage   71.0%   71.5%   +0.5%     
=======================================
  Files        135     136      +1     
  Lines      20751   20821     +70     
=======================================
+ Hits       14746   14906    +160     
+ Misses      6005    5915     -90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.