Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stdout example to default to all features #1734

Merged
merged 3 commits into from
May 10, 2024

Conversation

cijothomas
Copy link
Member

@cijothomas cijothomas commented May 10, 2024

Fixes #1732
#1732 (comment)

Logs are not yet part of this example, will add it later.

@cijothomas cijothomas requested a review from a team May 10, 2024 13:32
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.3%. Comparing base (348ec9e) to head (915bd4b).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1734     +/-   ##
=======================================
+ Coverage   71.0%   71.3%   +0.3%     
=======================================
  Files        135     136      +1     
  Lines      20751   20840     +89     
=======================================
+ Hits       14746   14877    +131     
+ Misses      6005    5963     -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth a CHANGLOG?

@cijothomas cijothomas merged commit 5e02f38 into open-telemetry:main May 10, 2024
20 checks passed
@cijothomas cijothomas deleted the cijothomas/stdoutexample branch May 10, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opentelemetry-stdout to have all features
3 participants