Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SDK's attributeset usage in stdout, add tests #1730

Merged

Conversation

cijothomas
Copy link
Member

AttributeSet is designed for Metric aggregation. It looks like it got accidentally used for stdout exporter. stdout already has its own AttributeSet and don't need the one from Metric module. I think AttributeSet from SDK can be made internal only, after I do another round of cleanup.

Also added some tests for Eq,Hash as we provide custom implementation. Ideally, we should test for all types, but just added for Float only as we use OrderedFloat to get Hash/Eq etc.

@cijothomas cijothomas requested a review from a team May 10, 2024 01:34
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.3%. Comparing base (348ec9e) to head (dd6b7f0).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1730     +/-   ##
=======================================
+ Coverage   71.0%   71.3%   +0.3%     
=======================================
  Files        135     136      +1     
  Lines      20751   20840     +89     
=======================================
+ Hits       14746   14879    +133     
+ Misses      6005    5961     -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 6d50e5f into open-telemetry:main May 10, 2024
18 of 20 checks passed
@cijothomas cijothomas deleted the cijothomas/attribute-set-fix branch May 10, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants