Remove SDK's attributeset usage in stdout, add tests #1730
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AttributeSet
is designed for Metric aggregation. It looks like it got accidentally used for stdout exporter. stdout already has its ownAttributeSet
and don't need the one from Metric module. I thinkAttributeSet
from SDK can be made internal only, after I do another round of cleanup.Also added some tests for Eq,Hash as we provide custom implementation. Ideally, we should test for all types, but just added for Float only as we use OrderedFloat to get Hash/Eq etc.