Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shared slices instead of references to owned vectors as return types #1729

Merged
merged 4 commits into from
May 10, 2024
Merged

Use shared slices instead of references to owned vectors as return types #1729

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3da3853
Use slices as return types
utpilla May 10, 2024
ba607a3
Merge branch 'main' into utpilla/Use-slices-instead-references-to-vecs
cijothomas May 10, 2024
0b4e955
Update CHANGELOG
utpilla May 10, 2024
1cde7a3
Merge branch 'main' into utpilla/Use-slices-instead-references-to-vecs
utpilla May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion opentelemetry-sdk/src/logs/log_emitter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ impl LoggerProvider {
}

/// Log processors associated with this provider.
pub fn log_processors(&self) -> &Vec<Box<dyn LogProcessor>> {
pub fn log_processors(&self) -> &[Box<dyn LogProcessor>] {
&self.inner.processors
}

Expand Down
2 changes: 1 addition & 1 deletion opentelemetry-sdk/src/trace/provider.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ impl TracerProvider {
}

/// Span processors associated with this provider
pub fn span_processors(&self) -> &Vec<Box<dyn SpanProcessor>> {
pub fn span_processors(&self) -> &[Box<dyn SpanProcessor>] {
&self.inner.processors
}

Expand Down
2 changes: 1 addition & 1 deletion opentelemetry-sdk/src/trace/span.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ impl Span {
data.end_time = opentelemetry::time::now();
}

match provider.span_processors().as_slice() {
match provider.span_processors() {
[] => {}
[processor] => {
processor.on_end(build_export_data(
Expand Down
Loading