Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ci #1720

Merged
merged 1 commit into from
May 7, 2024
Merged

fix ci #1720

merged 1 commit into from
May 7, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented May 7, 2024

Changes

hyper_tls feature flag is no where defined, but still being used. Removing it to fix the CI failure for it.

error: unexpected `cfg` condition value: `hyper_tls`
   --> opentelemetry-http/src/lib.rs:128:30
    |
128 | #[cfg(any(feature = "hyper", feature = "hyper_tls"))]

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb marked this pull request as ready for review May 7, 2024 17:42
@lalitb lalitb requested a review from a team May 7, 2024 17:42
@cijothomas cijothomas merged commit 8fd83e2 into open-telemetry:main May 7, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants