Metric attributes need sort with keys only #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utpilla
reviewed
May 7, 2024
| // "multi_thread" tokio flavor must be used else flush won't | ||
| // be able to make progress! | ||
| #[tokio::test(flavor = "multi_thread", worker_threads = 1)] | ||
| async fn counter_aggregation_attribute_order() { |
There was a problem hiding this comment.
Add a test to ensure that the dedupe + sort is case-sensitive as well.
utpilla
reviewed
May 7, 2024
| assert_eq!( | ||
| sum.data_points.len(), | ||
| 1, | ||
| "Expected only one data point as attributes are same, but just reordered." |
There was a problem hiding this comment.
We could probably add an assertion to verify that the attributes of the datapoint match what we expect.
lalitb
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HashKeyValueis a simple wrapper aroundKeyValueto provide hash, eq, ord implementations.The
Ordimplementation is required to ensure that attributes are treated the same irrespective of the order in which they are passed. This only requires a sort with theKeyalone.This PR simplifies the
Ordimplementation to be based of theKeypart alone from theKeyValue. Also added tests to validate that all measurements aggregate to the same point, irrespective of the order in which KeyValue pairs are passed.(This is part of a somewhat big refactor of Metrics SDK to significantly improve performance - offering short PRs to make reviews easy. Also intentionally keeping the tests modelled like integration tests, instead of unit tests - this is to reduce churn when refactoring, as lot of internals are expected to change, but the end user facing API need to be relatively stable, as we move towards beta release.)