Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI coverage for Windows #1714

Merged
merged 8 commits into from
May 7, 2024

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented May 6, 2024

Changes

  • Update CI workflow to run jobs on Windows as well

Note: Certain jobs from the CI workflow can only be run on Linx for now

@utpilla utpilla requested a review from a team May 6, 2024 19:49
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@cijothomas
Copy link
Member

Consider doing windows for only the test/stable for now, given it is much slower. We can add it for all, later.
Also see what other repos like tracing-rs is doing.

Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@utpilla
Copy link
Contributor Author

utpilla commented May 7, 2024

Consider doing windows for only the test/stable for now, given it is much slower. We can add it for all, later. Also see what other repos like tracing-rs is doing.

@cijothomas I checked the tracing repo and for non-Linux platforms, they only test using the stable version of Rust. Check this. I have updated the workflow to do the same. I have also updated code coverage workflow to only run on Linux.

@cijothomas cijothomas merged commit c7e0d50 into open-telemetry:main May 7, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants