Add CI coverage for Windows #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
reviewed
May 6, 2024
|
Consider doing windows for only the test/stable for now, given it is much slower. We can add it for all, later. |
ThomsonTan
reviewed
May 6, 2024
@cijothomas I checked the tracing repo and for non-Linux platforms, they only test using the stable version of Rust. Check this. I have updated the workflow to do the same. I have also updated code coverage workflow to only run on Linux. |
cijothomas
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Note: Certain jobs from the CI workflow can only be run on Linx for now