Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce public exposure of noops #1713

Closed

Conversation

cijothomas
Copy link
Member

Part of #1712
A lot of others noops are used by opentelemetry-sdk. I think sdk can find different ways to handle this. Will explore that later.

@cijothomas cijothomas requested a review from a team May 6, 2024 19:00
@lalitb
Copy link
Member

lalitb commented May 6, 2024

Not sure if I am interpreting correct, but seems the specs says they should be available(exposed?) in the API surface - https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/noop.md. Though in general agree to remove if they won't be ever used in libraries.

@cijothomas
Copy link
Member Author

Not sure if I am interpreting correct, but seems the specs says they should be available(exposed?) in the API surface - https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/noop.md. Though in general agree to remove if they won't be ever used in libraries.

It could be added back to public api of opentelemetry, if necessary. As long as all the APIs are no-op, even without exposing the no-op as-is, we should be good.

note: I don't think it is extra risky to expose the noops anyway, as the traits are anyway public!

@cijothomas cijothomas closed this May 6, 2024
@cijothomas cijothomas mentioned this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants