Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Semantic Convention v1.25.0 #1681

Merged
merged 5 commits into from
Apr 24, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Apr 24, 2024

Changes

Changes in v1.25.0:

  • Service attributes have been relocated to the registry
  • Attributes like service.name, previously defined under resources, are now categorized under attribute_groups in the registry.
  • The resource model now includes a reference to service.name as defined within the registry.

So, the code generator in generate-consts-from-spec.sh is now invoked for both resource and attribute_group.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team April 24, 2024 17:02
@cijothomas
Copy link
Member

FYI: open-telemetry/opentelemetry-dotnet#5539 This was removed by OTel .NET and being resurrected in contrib repo.

I think we may also move this to contrib in the future.

@lalitb
Copy link
Member Author

lalitb commented Apr 24, 2024

doc generation is failing, looking into this.

 Documenting opentelemetry-semantic-conventions v0.14.0 (/home/runner/work/opentelemetry-rust/opentelemetry-rust/opentelemetry-semantic-conventions)
error: unresolved link to `2`
   --> opentelemetry-semantic-conventions/src/trace.rs:660:96
    |
660 | /// All the command arguments (including the command/executable itself) run by the container. [2].
    |                                                                                                ^ no item named `2` in scope
    |
    = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
    = note: `-D rustdoc::broken-intra-doc-links` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(rustdoc::broken_intra_doc_links)]`

error: unresolved link to `2`
   --> opentelemetry-semantic-conventions/src/trace.rs:667:94
    |
667 | /// The full command run by the container as a single string representing the full command. [2].
    |                                                                                              ^ no item named `2` in scope
    |
    = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`

error: could not document `opentelemetry-semantic-conventions`

@lalitb
Copy link
Member Author

lalitb commented Apr 24, 2024

I think we may also move this to contrib in the future.

Yes good to discuss further on this. We can keep it in main repo as long as we can maintain/upgrade it without much of effort, which seems to be the case for now.

@lalitb
Copy link
Member Author

lalitb commented Apr 24, 2024

doc generation is failing, looking into this.

fixed now.

@cijothomas cijothomas merged commit 8a9a569 into open-telemetry:main Apr 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants