replace usages of TestSpanExporter with InMemorySpanExporter #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1626 +/- ##
=======================================
- Coverage 69.0% 69.0% -0.1%
=======================================
Files 139 139
Lines 19846 19833 -13
=======================================
- Hits 13703 13693 -10
+ Misses 6143 6140 -3 ☔ View full report in Codecov by Sentry. |
cijothomas
reviewed
Mar 17, 2024
| let _result = processor.shutdown(); | ||
| assert!(exporter.is_shutdown_called()); | ||
| assert!(exporter.get_finished_spans().unwrap().is_empty()); |
There was a problem hiding this comment.
nit: Add a comment saying, we indirectly test shutdown is called, by asserting that spans are empty in inmemoryexporter.
cijothomas
reviewed
Mar 17, 2024
| assert!(!exporter.is_shutdown_called()); | ||
| let span_data = new_test_export_span_data(); | ||
| processor.on_end(span_data.clone()); | ||
| assert_eq!(exporter.get_finished_spans().unwrap()[0], span_data); |
There was a problem hiding this comment.
nit: we only need to validate that finished spans is not empty before shutdown, and is empty after shutdown, to keep the test very focused on its purpose.
cijothomas
reviewed
Mar 17, 2024
cijothomas
reviewed
Mar 17, 2024
cijothomas
approved these changes
Mar 17, 2024
This reverts commit 1640854.
add comment
cijothomas
approved these changes
Mar 17, 2024
TommyCpp
approved these changes
Mar 17, 2024
|
looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Replaces usages of TestSpanExporter with InMemorySpanExporter
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes