-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test to validate log shutdown #1620
Add test to validate log shutdown #1620
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1620 +/- ##
=======================================
+ Coverage 67.8% 68.3% +0.4%
=======================================
Files 139 139
Lines 19687 19806 +119
=======================================
+ Hits 13363 13530 +167
+ Misses 6324 6276 -48 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Nice way to validate the scenario described in #1514 :)
Looking into the batch processor code, it seems to be doing the flush before shutdown. But good to validate this in separate test. opentelemetry-rust/opentelemetry-sdk/src/logs/log_processor.rs Lines 212 to 220 in 5ef3fd3
|
yes. that'd be a targetted test for processors to ensure shutdown() gives same effect as force_flush(). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice :)
Related to #1514, not quite the finish, but just a initial test.