-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use regular lock for simplespanprocessor #1612
Use regular lock for simplespanprocessor #1612
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1612 +/- ##
=======================================
- Coverage 67.0% 67.0% -0.1%
=======================================
Files 138 138
Lines 19515 19479 -36
=======================================
- Hits 13084 13058 -26
+ Misses 6431 6421 -10 ☔ View full report in Codecov by Sentry. |
…/cijothomas/opentelemetry-rust into cijothomas/simple-span-processor
Given the perf concern in #1409 I think it's worth call out explicitly in the comments of |
…/cijothomas/opentelemetry-rust into cijothomas/simple-span-processor
added for span and log processor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #1409
Changes
Match SimpleSpanProcessor to align with SimpleLogRecordProcessor.
Still haven't addressed this yet.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes