Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semantic convention to v1.24.0 #1596

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Mar 4, 2024

Changes

Update semantic convention from (current) v.1.21.0 to v1.24.0 - https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.24.0

Breaking changes across these two versions:

Trace attributes removed/renamed:

$ diff <(grep "pub const" ./trace_1.24.0.rs | sort) <(grep "pub const" ./trace_1.21.0.rs | sort)  | grep "> "
> pub const CLIENT_SOCKET_ADDRESS: &str = "client.socket.address";
> pub const CLIENT_SOCKET_PORT: &str = "client.socket.port";
> pub const DESTINATION_DOMAIN: &str = "destination.domain";
> pub const EVENT_DOMAIN: &str = "event.domain";
> pub const HTTP_RESEND_COUNT: &str = "http.resend_count";
> pub const MESSAGING_MESSAGE_PAYLOAD_COMPRESSED_SIZE_BYTES: &str =
> pub const MESSAGING_MESSAGE_PAYLOAD_SIZE_BYTES: &str = "messaging.message.payload_size_bytes";
> pub const POOL: &str = "pool";
> pub const SERVER_SOCKET_ADDRESS: &str = "server.socket.address";
> pub const SERVER_SOCKET_DOMAIN: &str = "server.socket.domain";
> pub const SERVER_SOCKET_PORT: &str = "server.socket.port";
> pub const SOURCE_DOMAIN: &str = "source.domain";
> pub const TYPE: &str = "type";
$

Resource attributes removed/renamed:

$ diff <(grep "pub const" ./resource_1.24.0.rs | sort) <(grep "pub const" ./resource_1.21.0.rs | sort)  | grep "> "
> pub const CONTAINER_IMAGE_TAG: &str = "container.image.tag";
> pub const TELEMETRY_AUTO_VERSION: &str = "telemetry.auto.version";
$

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team March 4, 2024 19:05
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.0%. Comparing base (7cff678) to head (c1d24c8).

❗ Current head c1d24c8 differs from pull request most recent head 04d9e81. Consider uploading reports for the commit 04d9e81 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1596   +/-   ##
=====================================
  Coverage   67.0%   67.0%           
=====================================
  Files        138     138           
  Lines      19515   19515           
=====================================
  Hits       13084   13084           
  Misses      6431    6431           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas
Copy link
Member

https://github.com/open-telemetry/opentelemetry-rust/tree/main/opentelemetry-semantic-conventions/scripts/templates we don't have metric attributes generated? is that something we can add as well?

@lalitb
Copy link
Member Author

lalitb commented Mar 5, 2024

https://github.com/open-telemetry/opentelemetry-rust/tree/main/opentelemetry-semantic-conventions/scripts/templates we don't have metric attributes generated? is that something we can add as well?

Yes, there were some docker errors while generating the source files for metrics. So thought of publishing it as separate PR.

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
@cijothomas cijothomas merged commit 4aa4827 into open-telemetry:main Mar 5, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants