Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf requirement from 2.14 to 3.3 #1548

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 16, 2024

Updates the requirements on protobuf to permit the latest version.

Changelog

Sourced from protobuf's changelog.

[3.3.0] - 2023-09-30

[3.2.0] - 2022-09-26

[3.1.0] - 2022-06-22

[3.0.3] - 2022-05-31

[3.0.2] - 2022-05-06

[3.0.1] - 2022-05-01

  • More up to date readme.

[3.0.0] - 2022-05-01

  • New stable version released.

Before version 3

Changelog before version 3

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Updates the requirements on [protobuf](https://github.com/stepancheg/rust-protobuf) to permit the latest version.
- [Changelog](https://github.com/stepancheg/rust-protobuf/blob/master/CHANGELOG.md)
- [Commits](stepancheg/rust-protobuf@v2.14.0...v3.3.0)

---
updated-dependencies:
- dependency-name: protobuf
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team February 16, 2024 21:52
@dependabot dependabot bot added dependencies dependencies needs upgrade rust Pull requests that update Rust code labels Feb 16, 2024
@hdost
Copy link
Contributor

hdost commented Feb 17, 2024

I think this one would require a bit of testing, i'm aware there are some significant differences between the two proto versions and I'm not sure if these are user facing changes or not. Will have to investigate.

@TommyCpp
Copy link
Contributor

I think the major blocker was grpc-io didn't support a newer version. With that gone, we can probably try to upgrade tonic manually.

@lalitb
Copy link
Member

lalitb commented Feb 18, 2024

With that gone, we can probably try to upgrade tonic manually.

I think tonic should be good, as it depends on prost, and we already use it's latest version.

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 25, 2024

Dependabot attempted to update this pull request, but because the branch dependabot/cargo/protobuf-3.3 is protected it was unable to do so.

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 26, 2024

Superseded by #1580.

@dependabot dependabot bot closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies dependencies needs upgrade rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants