Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stress test more realistic #1531

Merged

Conversation

cijothomas
Copy link
Member

For logs - removes the custom Resource, and let the default resource be automatically added. There isn't a super easy way to keep the default + add my own attribute, as setting my Resource overrides the default! Will fix this later.
This will make it consistent across traces and metrics which all use default Resources only.

For traces - adds a noop processor. Without processor, we are not measuring the real SDK cost. (We could alternatively use a processor with noop exporter as well)

@cijothomas cijothomas requested a review from a team February 14, 2024 19:07
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (054b0c8) 62.4% compared to head (93d179d) 62.4%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1531   +/-   ##
=====================================
  Coverage   62.4%   62.4%           
=====================================
  Files        144     144           
  Lines      19891   19891           
=====================================
  Hits       12426   12426           
  Misses      7465    7465           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit f80d754 into open-telemetry:main Feb 14, 2024
14 checks passed
@cijothomas cijothomas deleted the cijothomas/stress-test-realistic branch February 14, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants