Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't return empty string when trace header is not present #1523

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

TommyCpp
Copy link
Contributor

@TommyCpp TommyCpp commented Feb 11, 2024

Fixes #1475
Design discussion issue (if applicable) #

Changes

  • if trace header is not present. Just return default

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (8688e7e) 61.8% compared to head (1068d8d) 61.9%.
Report is 4 commits behind head on main.

Files Patch % Lines
opentelemetry-sdk/src/metrics/periodic_reader.rs 92.3% 4 Missing ⚠️
opentelemetry-sdk/src/logs/log_emitter.rs 90.9% 1 Missing ⚠️
opentelemetry/src/logs/noop.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1523   +/-   ##
=====================================
  Coverage   61.8%   61.9%           
=====================================
  Files        144     144           
  Lines      19810   19862   +52     
=====================================
+ Hits       12256   12303   +47     
- Misses      7554    7559    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TommyCpp TommyCpp marked this pull request as ready for review February 13, 2024 07:36
@TommyCpp TommyCpp requested a review from a team February 13, 2024 07:36
Copy link
Contributor

@hdost hdost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! are there tests we want to add?

@cijothomas cijothomas merged commit 64b11e0 into open-telemetry:main Feb 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Avoid parsing empty strings into TraceId
4 participants