Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce cost of no attribute counters #1519

Merged

Final test fix

6b30d7e
Select commit
Loading
Failed to load commit list.
Merged

Reduce cost of no attribute counters #1519

Final test fix
6b30d7e
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Feb 14, 2024 in 0s

62.5% (+0.1%) compared to 054b0c8

View this Pull Request on Codecov

62.5% (+0.1%) compared to 054b0c8

Details

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (054b0c8) 62.4% compared to head (6b30d7e) 62.5%.
Report is 1 commits behind head on main.

❗ Current head 6b30d7e differs from pull request most recent head a8d4bfa. Consider uploading reports for the commit a8d4bfa to get more accurate results

Files Patch % Lines
opentelemetry-sdk/src/metrics/internal/sum.rs 77.1% 19 Missing ⚠️
opentelemetry-sdk/src/metrics/internal/mod.rs 68.0% 15 Missing ⚠️
opentelemetry-sdk/src/metrics/mod.rs 99.1% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1519     +/-   ##
=======================================
+ Coverage   62.4%   62.5%   +0.1%     
=======================================
  Files        144     144             
  Lines      19891   20211    +320     
=======================================
+ Hits       12426   12647    +221     
- Misses      7465    7564     +99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.