Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move MikeGoldsmith to emeritus #1504

Merged

Conversation

MikeGoldsmith
Copy link
Member

Changes

I was part of the original group who helped get this project going and such was added as an approver. I haven't been involved in this group for a while so should be removed from the @open-telemetry/rust-approvers group.

This PR moves myself to Emeritus group in Contributing file too.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@MikeGoldsmith MikeGoldsmith requested a review from a team January 31, 2024 12:44
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d4a6b3e) 63.8% compared to head (d9b9539) 63.7%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1504     +/-   ##
=======================================
- Coverage   63.8%   63.7%   -0.1%     
=======================================
  Files        144     144             
  Lines      19983   19983             
=======================================
- Hits       12750   12741      -9     
- Misses      7233    7242      +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your contributions @MikeGoldsmith.

@cijothomas
Copy link
Member

Thanks @MikeGoldsmith for your contributions.
Apologies for missing your name in the Emeritus list.

@cijothomas cijothomas merged commit 989fa3b into open-telemetry:main Jan 31, 2024
14 checks passed
@cijothomas
Copy link
Member

removed from the @open-telemetry/rust-approvers group.

@jtescher Can you update this group with the current list?

@jtescher
Copy link
Member

Thanks @MikeGoldsmith, removed.

@MikeGoldsmith MikeGoldsmith deleted the mike/update-contributing branch February 1, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants