Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aggregation bug due to stale hash value #1422

Merged
merged 7 commits into from
Mar 13, 2024

Conversation

cijothomas
Copy link
Member

Fixes #1418
Accidental side effect of this PR: #1407

Changes

Re-calculates hash, if attributes are changed, which can occur when View is configured to drop attributes.
Not adding changelog, as this can be part of the #1407 itself, and we haven't released with that yet.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@cijothomas cijothomas requested a review from a team December 1, 2023 21:06
@cijothomas
Copy link
Member Author

Maybe better to fold this into #1421

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.8%. Comparing base (35c7803) to head (eda0001).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1422     +/-   ##
=======================================
+ Coverage   67.3%   67.8%   +0.4%     
=======================================
  Files        138     139      +1     
  Lines      19654   19687     +33     
=======================================
+ Hits       13243   13363    +120     
+ Misses      6411    6324     -87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas
Copy link
Member Author

Maybe better to fold this into #1421

This needs to proceed as-is now, as 1421 is reverted.

@cijothomas cijothomas closed this Mar 13, 2024
@cijothomas cijothomas reopened this Mar 13, 2024
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@cijothomas cijothomas merged commit a8b308a into open-telemetry:main Mar 13, 2024
30 of 31 checks passed
@cijothomas cijothomas deleted the cijothomas/fix-hash branch March 13, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Aggregation issues when using Views to drop attributes
2 participants