-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aggregation bug due to stale hash value #1422
Fix aggregation bug due to stale hash value #1422
Conversation
Maybe better to fold this into #1421 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1422 +/- ##
=======================================
+ Coverage 67.3% 67.8% +0.4%
=======================================
Files 138 139 +1
Lines 19654 19687 +33
=======================================
+ Hits 13243 13363 +120
+ Misses 6411 6324 -87 ☔ View full report in Codecov by Sentry. |
This needs to proceed as-is now, as 1421 is reverted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
Fixes #1418
Accidental side effect of this PR: #1407
Changes
Re-calculates hash, if attributes are changed, which can occur when View is configured to drop attributes.
Not adding changelog, as this can be part of the #1407 itself, and we haven't released with that yet.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes