Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed futures-channel from opentelemetry dependencies #1229

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Removed futures-channel from opentelemetry dependencies #1229

merged 1 commit into from
Aug 28, 2023

Conversation

shaun-cox
Copy link
Contributor

@shaun-cox shaun-cox commented Aug 24, 2023

Fixes #1201

Changes

Removed futures-channel from opentelemetry dependencies. It was only used for a few fallible conversions to LogError and TraceError types, only one of which was being used by opentelemetry-stackdriver.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes

@shaun-cox shaun-cox changed the title Removed futures-channel from opentelemetry dependencies #1201 Removed futures-channel from opentelemetry dependencies Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6603a58) 49.3% compared to head (53439f3) 49.3%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1229   +/-   ##
=====================================
  Coverage   49.3%   49.3%           
=====================================
  Files        173     173           
  Lines      20978   20968   -10     
=====================================
  Hits       10349   10349           
+ Misses     10629   10619   -10     
Files Changed Coverage Δ
opentelemetry-stackdriver/src/lib.rs 30.8% <0.0%> (-0.1%) ⬇️
opentelemetry/src/logs/mod.rs 0.0% <ø> (ø)
opentelemetry/src/trace/mod.rs 92.6% <ø> (+11.8%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaun-cox shaun-cox marked this pull request as ready for review August 28, 2023 20:02
@shaun-cox shaun-cox requested a review from a team August 28, 2023 20:02
Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shaun-cox

@jtescher jtescher merged commit 08119c4 into open-telemetry:main Aug 28, 2023
@shaun-cox shaun-cox deleted the fix_1201 branch August 28, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opentelemetry_api should not depend on futures_channel
2 participants