Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs API/SDK - few perf improvements #1134

Merged
merged 4 commits into from
Jul 10, 2023

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Jun 27, 2023

Fixes #

Changes

Few perf improvements in logs api/sdk picked from the recent changes in tracing api/sdk by @shaun-cox ( #1093 and #1129), so:

  • change sdk:::Logger to hold Arc instead of whole InstrumentationLib instance, so cloning logger instance is much cheaper.
  • API to returns a new versioned logger with the given instrumentation library. This will allow user to share the instrumentation library with multiple loggers.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team June 27, 2023 18:27
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.1 ⚠️

Comparison is base (fa37b99) 49.8% compared to head (ab2938c) 49.8%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1134     +/-   ##
=======================================
- Coverage   49.8%   49.8%   -0.1%     
=======================================
  Files        171     171             
  Lines      20238   20253     +15     
=======================================
  Hits       10092   10092             
- Misses     10146   10161     +15     
Impacted Files Coverage Δ
opentelemetry-api/src/global/logs.rs 0.0% <0.0%> (ø)
opentelemetry-api/src/logs/logger.rs 0.0% <0.0%> (ø)
opentelemetry-api/src/logs/noop.rs 0.0% <0.0%> (ø)
opentelemetry-sdk/src/logs/log_emitter.rs 0.0% <0.0%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@djc
Copy link
Contributor

djc commented Jun 28, 2023

@shaun-cox could help review this?

Copy link
Contributor

@shaun-cox shaun-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this over!

@TommyCpp TommyCpp merged commit 309b4e5 into open-telemetry:main Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants