-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stdout exporter example for Logs. #1072
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
//! run with `$ cargo run --example basic --all-features | ||
|
||
#[cfg(all(feature = "logs", feature = "trace"))] | ||
use opentelemetry_api::{ | ||
logs::LoggerProvider as _, | ||
logs::LogRecordBuilder, | ||
logs::Logger, | ||
logs::Severity, | ||
trace::{Span, Tracer, TracerProvider as _, mark_span_as_active}, | ||
Context, KeyValue, | ||
}; | ||
#[cfg(all(feature = "logs", feature = "trace"))] | ||
use opentelemetry_sdk::{ | ||
logs::LoggerProvider, | ||
runtime, | ||
trace::TracerProvider, | ||
}; | ||
|
||
#[cfg(all(feature = "logs", feature = "trace"))] | ||
fn init_trace() -> TracerProvider { | ||
let exporter = opentelemetry_stdout::SpanExporter::default(); | ||
TracerProvider::builder() | ||
.with_simple_exporter(exporter) | ||
.build() | ||
} | ||
|
||
#[cfg(all(feature = "logs", feature = "trace"))] | ||
fn init_logger() -> LoggerProvider { | ||
let exporter = opentelemetry_stdout::LogExporter::default(); | ||
LoggerProvider::builder() | ||
.with_simple_exporter(exporter) | ||
.build() | ||
} | ||
|
||
#[tokio::main] | ||
#[cfg(all(feature = "logs", feature = "trace"))] | ||
async fn main() -> Result<(), Box<dyn std::error::Error>> { | ||
use opentelemetry_api::logs::LogRecordBuilder; | ||
|
||
let logger_provider = init_logger(); | ||
let tracer_provider = init_trace(); | ||
let cx = Context::new(); | ||
|
||
let tracer = tracer_provider.tracer("stdout-test"); | ||
let logger = logger_provider.versioned_logger("stdout-test", None, None, None, true); | ||
let mut span = tracer.start("test_span"); | ||
span.set_attribute(KeyValue::new("test_key", "test_value")); | ||
let span_active = mark_span_as_active(span); | ||
let log_record = LogRecordBuilder::new() | ||
.with_body("test log".into()) | ||
.with_severity_number(Severity::Info) | ||
.build(); | ||
logger.emit(log_record); | ||
drop(span_active); | ||
Ok(()) | ||
} | ||
#[cfg(not(all(feature = "logs", feature = "trace")))] | ||
fn main() {} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should not be showing this, as this is never intended for end-users to use like this. This could be part of a tutorial for "how to write own appenders", or shown with existing log api like in this PR: #1071
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes agree, but I think it is still helpful to have a vendor neutral example (with no external dependencies) using only core API and SDK - which would be useful to both - external developers who want to (somehow) use only the core api and sdk in their application, and the developers creating their own appenders/subscriber. We can add a disclaimer as comment for
LogRecordBuilder
that it is not recommended for front facing API if that helps.Said that, I don't have strong opinion, and can close this PR if we all agree this not to be good showcase example :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Options:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd go for option 1 as that seems least confusing for lower context people.