Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpanBuilder should not allow with_span_id and with_trace_id #2743

Open
cijothomas opened this issue Mar 3, 2025 · 2 comments
Open

SpanBuilder should not allow with_span_id and with_trace_id #2743

cijothomas opened this issue Mar 3, 2025 · 2 comments

Comments

@cijothomas
Copy link
Member

https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry/src/trace/tracer.rs#L242
with_trace_id, with_span_id allow one to specify TraceId,SpanId via builder - there is no such capability in the specification.
If user want to control traceid,spanid generation, they can use IdGenerator.

This must be removed from SpanBuilder

@Shunpoco
Copy link
Contributor

Shunpoco commented Mar 6, 2025

@cijothomas I'd like to take this issue (and perhaps similar issues you put above).
Do I need to do anything other than just removing those methods from SpanBuilder?
It looks that there is no place which uses them in this repository.

@cijothomas
Copy link
Member Author

This may have same dependency breaking issue as #2753 (comment)

If tracing-opentelemetry is not dependent on this, then we can remove it right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants