Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpanBuilder should not allow with_status #2745

Open
cijothomas opened this issue Mar 3, 2025 · 4 comments
Open

SpanBuilder should not allow with_status #2745

cijothomas opened this issue Mar 3, 2025 · 4 comments

Comments

@cijothomas
Copy link
Member

Similar to #2743

I am not sure what is the need of with_status in the SpanBuilder. SpanBuilder is used to create a new Span, at which point the status should be unknown. It totally is valid to have this API on the Span itself as that'll be called only after a Span has been created.

@cijothomas cijothomas added this to the Tracing API Stable milestone Mar 3, 2025
@TommyCpp
Copy link
Contributor

TommyCpp commented Mar 5, 2025

Used by tracing-opentelemtry here

(not exactly the method but I assume you are referring to the abilty to set the status field in SpanBuilder)

@cijothomas
Copy link
Member Author

Yes, it is similar to #2753
We cannot stabilize Otel Tracing API with these APIs exposed. (A lot of special casing to support tracing-opentelemetry actually).
Hopefully @bantonsson's work will allow us to trim public APIs.

@TommyCpp
Copy link
Contributor

TommyCpp commented Mar 5, 2025

Let's keep this issue in a blocked state until then? IIRC we removed some API tracing-opentelemetry used and had to add it back. Want to avoid that until we have a good replacement in place

@cijothomas
Copy link
Member Author

Yes okay to keep them now to not break tracing-opentelemetry. But I don't think we can delay 1.0 indefinitely either. Need to see if tracing-opentelemetry maintainers can commit a timeframe before tracing-opentelemetry can be modified to not depend on these APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants