Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Utkarsh Umesan Pillai <66651184+utpilla@users.noreply.github.com>
  • Loading branch information
cijothomas and utpilla authored Mar 10, 2025
1 parent 06e796c commit 7a0024e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions opentelemetry-otlp/src/exporter/tonic/logs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ impl LogExporter for TonicLogsClient {

fn shutdown(&self) -> OTelSdkResult {
// TODO: Implement actual shutdown
// Due to the use to tokio::sync::Mutex to guard
// the inner client, we need to lock the mutex
// Due to the use of tokio::sync::Mutex to guard
// the inner client, we need to await the call to lock the mutex
// and that requires async runtime.
// It is possible to fix this by using
// a dedicated thread just to handle shutdown.
Expand Down
2 changes: 1 addition & 1 deletion opentelemetry-sdk/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
`scope` name but instead passes the incoming `name` when invoking
`event_enabled` on processors.
- **Breaking** for custom LogExporter authors: `shutdown()` method in
`LogExporter` trait no longer requires a mutable ref to self. If the exporter
`LogExporter` trait no longer requires a mutable ref to `self`. If the exporter
needs to mutate state, it should rely on interior mutability.
[2764](https://github.com/open-telemetry/opentelemetry-rust/pull/2764)

Expand Down

0 comments on commit 7a0024e

Please sign in to comment.