Skip to content

Commit 7280936

Browse files
committed
fix lint
1 parent 6ee6e31 commit 7280936

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

opentelemetry-appender-log/src/lib.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ where
128128
if self.enabled(record.metadata()) {
129129
let mut log_record = self.logger.create_log_record();
130130
log_record.set_severity_number(severity_of_level(record.level()));
131-
log_record.set_severity_text(record.level().as_str().into());
131+
log_record.set_severity_text(record.level().as_str());
132132
log_record.set_body(AnyValue::from(record.args().to_string()));
133133
log_record.add_attributes(log_attributes(record.key_values()));
134134
log_record.set_target(record.metadata().target().to_string());

opentelemetry-appender-tracing/src/layer.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ where
176176
log_record.set_target(meta.target().to_string());
177177
log_record.set_event_name(meta.name());
178178
log_record.set_severity_number(severity_of_level(meta.level()));
179-
log_record.set_severity_text(meta.level().as_str().into());
179+
log_record.set_severity_text(meta.level().as_str());
180180
let mut visitor = EventVisitor::new(&mut log_record);
181181
#[cfg(feature = "experimental_metadata_attributes")]
182182
visitor.visit_experimental_metadata(meta);

opentelemetry-sdk/benches/log.rs

+5-5
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ fn logging_comparable_to_appender(c: &mut Criterion) {
131131
log_record.set_target("my-target".to_string());
132132
log_record.set_event_name("CheckoutFailed");
133133
log_record.set_severity_number(Severity::Warn);
134-
log_record.set_severity_text("WARN".into());
134+
log_record.set_severity_text("WARN");
135135
log_record.add_attribute("book_id", "12345");
136136
log_record.add_attribute("book_title", "Rust Programming Adventures");
137137
log_record.add_attribute("message", "Unable to process checkout.");
@@ -275,7 +275,7 @@ fn criterion_benchmark(c: &mut Criterion) {
275275
log_record.set_timestamp(now);
276276
log_record.set_observed_timestamp(now);
277277
log_record.set_severity_number(Severity::Warn);
278-
log_record.set_severity_text(Severity::Warn.name().into());
278+
log_record.set_severity_text(Severity::Warn.name());
279279
logger.emit(log_record);
280280
});
281281

@@ -285,7 +285,7 @@ fn criterion_benchmark(c: &mut Criterion) {
285285
log_record.set_timestamp(now);
286286
log_record.set_observed_timestamp(now);
287287
log_record.set_severity_number(Severity::Warn);
288-
log_record.set_severity_text(Severity::Warn.name().into());
288+
log_record.set_severity_text(Severity::Warn.name());
289289
log_record.add_attribute("name", "my-event-name");
290290
log_record.add_attribute("event.id", 20);
291291
log_record.add_attribute("user.name", "otel");
@@ -299,7 +299,7 @@ fn criterion_benchmark(c: &mut Criterion) {
299299
log_record.set_timestamp(now);
300300
log_record.set_observed_timestamp(now);
301301
log_record.set_severity_number(Severity::Warn);
302-
log_record.set_severity_text(Severity::Warn.name().into());
302+
log_record.set_severity_text(Severity::Warn.name());
303303
log_record.add_attribute("name", "my-event-name");
304304
log_record.add_attribute("event.id", 20);
305305
log_record.add_attribute("user.name", "otel");
@@ -338,7 +338,7 @@ fn criterion_benchmark(c: &mut Criterion) {
338338
log_record.set_timestamp(now);
339339
log_record.set_observed_timestamp(now);
340340
log_record.set_severity_number(Severity::Warn);
341-
log_record.set_severity_text(Severity::Warn.name().into());
341+
log_record.set_severity_text(Severity::Warn.name());
342342
log_record.add_attributes(attributes.clone());
343343
logger.emit(log_record);
344344
});

opentelemetry-sdk/src/logs/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ mod tests {
4141
let logger = logger_provider.logger("test-logger");
4242
let mut log_record = logger.create_log_record();
4343
log_record.set_severity_number(Severity::Error);
44-
log_record.set_severity_text("Error".into());
44+
log_record.set_severity_text("Error");
4545

4646
// Adding attributes using a vector with explicitly constructed Key and AnyValue objects.
4747
log_record.add_attributes(vec![

opentelemetry-stdout/src/logs/transform.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -115,11 +115,11 @@ impl From<opentelemetry_sdk::export::logs::LogData> for LogRecord {
115115
.collect::<Vec<KeyValue>>(); // Collect into a Vec<KeyValue>s
116116

117117
#[cfg(feature = "populate-logs-event-name")]
118-
if let Some(event_name) = &value.record.event_name {
118+
if let Some(event_name) = value.record.event_name {
119119
let mut attributes_with_name = attributes;
120120
attributes_with_name.push(KeyValue::from((
121121
"name".into(),
122-
opentelemetry::Value::String(event_name.clone().into()),
122+
opentelemetry::Value::String(event_name.into()),
123123
)));
124124
attributes_with_name
125125
} else {

0 commit comments

Comments
 (0)