add severity text

Author: lalitb

opentelemetry-sdk/src/logs/record.rs

@@ -26,7 +26,8 @@ pub struct LogRecord {
     pub trace_context: Option<TraceContext>,
 
     /// The original severity string from the source
-    pub severity_text: Option<Cow<'static, str>>,
+    pub severity_text: Option<&'static str>,
+
     /// The corresponding severity value, normalized
     pub severity_number: Option<Severity>,
 
@@ -58,7 +59,7 @@ impl opentelemetry::logs::LogRecord for LogRecord {
         self.observed_timestamp = Some(timestamp);
     }
 
-    fn set_severity_text(&mut self, severity_text: Cow<'static, str>) {
+    fn set_severity_text(&mut self, severity_text: &'static str) {
         self.severity_text = Some(severity_text);
     }
 
@@ -180,9 +181,8 @@ mod tests {
     #[test]
     fn test_set_severity_text() {
         let mut log_record = LogRecord::default();
-        let severity_text: Cow<'static, str> = "ERROR".into(); // Explicitly typed
-        log_record.set_severity_text(severity_text);
-        assert_eq!(log_record.severity_text, Some(Cow::Borrowed("ERROR")));
+        log_record.set_severity_text("ERROR");
+        assert_eq!(log_record.severity_text, Some("ERROR"));
     }
 
     #[test]
@@ -248,7 +248,7 @@ mod tests {
             target: Some(Cow::Borrowed("foo::bar")),
             timestamp: Some(SystemTime::now()),
             observed_timestamp: Some(SystemTime::now()),
-            severity_text: Some(Cow::Borrowed("ERROR")),
+            severity_text: Some("ERROR"),
             severity_number: Some(Severity::Error),
             body: Some(AnyValue::String("Test body".into())),
             attributes: Some(vec![(Key::new("key"), AnyValue::String("value".into()))]),

opentelemetry-stdout/src/logs/transform.rs

@@ -91,7 +91,7 @@ struct LogRecord {
     observed_time: SystemTime,
     severity_number: u32,
     #[serde(skip_serializing_if = "Option::is_none")]
-    severity_text: Option<Cow<'static, str>>,
+    severity_text: Option<&'static str>,
     #[serde(skip_serializing_if = "Option::is_none")]
     body: Option<Value>,
     attributes: Vec<KeyValue>,

opentelemetry/src/logs/noop.rs

@@ -47,7 +47,7 @@ impl LogRecord for NoopLogRecord {
     #[inline]
     fn set_observed_timestamp(&mut self, _timestamp: SystemTime) {}
     #[inline]
-    fn set_severity_text(&mut self, _text: Cow<'static, str>) {}
+    fn set_severity_text(&mut self, _text: &'static str) {}
     #[inline]
     fn set_severity_number(&mut self, _number: Severity) {}
     #[inline]

opentelemetry/src/logs/record.rs

@@ -4,7 +4,7 @@ use std::{borrow::Cow, collections::HashMap, time::SystemTime};
 /// SDK implemented trait for managing log records
 pub trait LogRecord {
     /// Sets the `event_name` of a record
-    fn set_event_name(&mut self, _name: &'static str);
+    fn set_event_name(&mut self, name: &'static str);
 
     /// Sets the `target` of a record.
     /// Currently, both `opentelemetry-appender-tracing` and `opentelemetry-appender-log` create a single logger
@@ -21,7 +21,7 @@ pub trait LogRecord {
     fn set_observed_timestamp(&mut self, timestamp: SystemTime);
 
     /// Sets severity as text.
-    fn set_severity_text(&mut self, text: Cow<'static, str>);
+    fn set_severity_text(&mut self, text: &'static str);
 
     /// Sets severity as a numeric value.
     fn set_severity_number(&mut self, number: Severity);