Skip to content

Commit 6ee6e31

Browse files
committed
add severity text
1 parent 5781f50 commit 6ee6e31

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

opentelemetry-sdk/src/logs/record.rs

+6-6
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ pub struct LogRecord {
2626
pub trace_context: Option<TraceContext>,
2727

2828
/// The original severity string from the source
29-
pub severity_text: Option<Cow<'static, str>>,
29+
pub severity_text: Option<&'static str>,
30+
3031
/// The corresponding severity value, normalized
3132
pub severity_number: Option<Severity>,
3233

@@ -58,7 +59,7 @@ impl opentelemetry::logs::LogRecord for LogRecord {
5859
self.observed_timestamp = Some(timestamp);
5960
}
6061

61-
fn set_severity_text(&mut self, severity_text: Cow<'static, str>) {
62+
fn set_severity_text(&mut self, severity_text: &'static str) {
6263
self.severity_text = Some(severity_text);
6364
}
6465

@@ -180,9 +181,8 @@ mod tests {
180181
#[test]
181182
fn test_set_severity_text() {
182183
let mut log_record = LogRecord::default();
183-
let severity_text: Cow<'static, str> = "ERROR".into(); // Explicitly typed
184-
log_record.set_severity_text(severity_text);
185-
assert_eq!(log_record.severity_text, Some(Cow::Borrowed("ERROR")));
184+
log_record.set_severity_text("ERROR");
185+
assert_eq!(log_record.severity_text, Some("ERROR"));
186186
}
187187

188188
#[test]
@@ -248,7 +248,7 @@ mod tests {
248248
target: Some(Cow::Borrowed("foo::bar")),
249249
timestamp: Some(SystemTime::now()),
250250
observed_timestamp: Some(SystemTime::now()),
251-
severity_text: Some(Cow::Borrowed("ERROR")),
251+
severity_text: Some("ERROR"),
252252
severity_number: Some(Severity::Error),
253253
body: Some(AnyValue::String("Test body".into())),
254254
attributes: Some(vec![(Key::new("key"), AnyValue::String("value".into()))]),

opentelemetry-stdout/src/logs/transform.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ struct LogRecord {
9191
observed_time: SystemTime,
9292
severity_number: u32,
9393
#[serde(skip_serializing_if = "Option::is_none")]
94-
severity_text: Option<Cow<'static, str>>,
94+
severity_text: Option<&'static str>,
9595
#[serde(skip_serializing_if = "Option::is_none")]
9696
body: Option<Value>,
9797
attributes: Vec<KeyValue>,

opentelemetry/src/logs/noop.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ impl LogRecord for NoopLogRecord {
4747
#[inline]
4848
fn set_observed_timestamp(&mut self, _timestamp: SystemTime) {}
4949
#[inline]
50-
fn set_severity_text(&mut self, _text: Cow<'static, str>) {}
50+
fn set_severity_text(&mut self, _text: &'static str) {}
5151
#[inline]
5252
fn set_severity_number(&mut self, _number: Severity) {}
5353
#[inline]

opentelemetry/src/logs/record.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use std::{borrow::Cow, collections::HashMap, time::SystemTime};
44
/// SDK implemented trait for managing log records
55
pub trait LogRecord {
66
/// Sets the `event_name` of a record
7-
fn set_event_name(&mut self, _name: &'static str);
7+
fn set_event_name(&mut self, name: &'static str);
88

99
/// Sets the `target` of a record.
1010
/// Currently, both `opentelemetry-appender-tracing` and `opentelemetry-appender-log` create a single logger
@@ -21,7 +21,7 @@ pub trait LogRecord {
2121
fn set_observed_timestamp(&mut self, timestamp: SystemTime);
2222

2323
/// Sets severity as text.
24-
fn set_severity_text(&mut self, text: Cow<'static, str>);
24+
fn set_severity_text(&mut self, text: &'static str);
2525

2626
/// Sets severity as a numeric value.
2727
fn set_severity_number(&mut self, number: Severity);

0 commit comments

Comments
 (0)