Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add synk repository scan #290

Merged
merged 2 commits into from
Feb 8, 2025
Merged

Conversation

hanshal101
Copy link
Contributor

Description: This PR adds the Synk Setup Action to check for vulnerabilities to the opentelemetry-network repo.

Link to tracking Issue: #158

Testing: NA

Documentation: NA

Signed-off-by: Hanshal Mehta <122217807+hanshal101@users.noreply.github.com>
Copy link

linux-foundation-easycla bot commented Feb 8, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Signed-off-by: Hanshal Mehta <122217807+hanshal101@users.noreply.github.com>
@yonch yonch merged commit 69804ab into open-telemetry:main Feb 8, 2025
7 of 11 checks passed
@yonch
Copy link
Contributor

yonch commented Feb 8, 2025

Thank you for the contribution!

@yonch
Copy link
Contributor

yonch commented Feb 8, 2025

The check seems to fail: https://github.com/open-telemetry/opentelemetry-network/actions/runs/13217009651/job/36897413920

Any idea why this is happening?

@hanshal101
Copy link
Contributor Author

The check seems to fail: https://github.com/open-telemetry/opentelemetry-network/actions/runs/13217009651/job/36897413920

Any idea why this is happening?

Hey, I think I missed something so there's a flag --unmanaged in the synk CLI, which can be used for C++ only.
Docs: https://docs.snyk.io/snyk-cli/commands/test#unmanaged

Should I create a new PR adding this flag?

@yonch
Copy link
Contributor

yonch commented Feb 9, 2025

Yes please, if you think that will solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants