Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OF#4917] Update buttons styling (buttons position) #787

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Jan 27, 2025

Closes open-formulieren/open-forms#4917

The following screenshots show the new position of the buttons (mobile version already handles the correct order):

  • Start page

startpage

  • Form step

formstep

  • Summary

summary

@vaszig vaszig changed the title [OF#4917] Update buttons styling [OF#4917] Update buttons styling (buttons position) Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Bundle Report

Changes will increase total bundle size by 143 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@open-formulieren/sdk-OpenForms-umd 4.78MB 75 bytes (0.0%) ⬆️
@open-formulieren/sdk-esm 4.75MB 68 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: @open-formulieren/sdk-OpenForms-umd

Assets Changed:

Asset Name Size Change Total Size Change (%)
open-*.js 75 bytes 3.49MB 0.0%

Files in open-*.js:

  • ./src/components/ButtonsToolbar/index.jsx → Total Size: 2.84kB

  • ./src/components/modals/FormStepSaveModal.jsx → Total Size: 8.06kB

  • ./src/components/EmailVerification/EmailVerificationForm.jsx → Total Size: 5.9kB

  • ./src/components/Toolbar.jsx → Total Size: 945 bytes

  • ./src/components/Summary/GenericSummary.jsx → Total Size: 3.18kB

  • ./src/components/SummaryConfirmation/index.jsx → Total Size: 2.25kB

  • ./src/components/appointments/cancel/CancelAppointment.jsx → Total Size: 5.47kB

  • ./src/components/AbortButton/AbortButton.jsx → Total Size: 1.88kB

  • ./src/components/Sessions/SessionTrackerModal.jsx → Total Size: 4.33kB

view changes for bundle: @open-formulieren/sdk-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/sdk-*.js 78 bytes 1.01MB 0.01%
assets/index-*.js -10 bytes 25.26kB -0.04%

Files in assets/sdk-*.js:

  • ./src/components/modals/FormStepSaveModal.jsx → Total Size: 8.05kB

  • ./src/components/Sessions/SessionTrackerModal.jsx → Total Size: 4.33kB

  • ./src/components/Summary/GenericSummary.jsx → Total Size: 3.18kB

  • ./src/components/EmailVerification/EmailVerificationForm.jsx → Total Size: 5.9kB

  • ./src/components/SummaryConfirmation/index.jsx → Total Size: 2.25kB

  • ./src/components/Toolbar.jsx → Total Size: 945 bytes

  • ./src/components/AbortButton/AbortButton.jsx → Total Size: 1.88kB

  • ./src/components/ButtonsToolbar/index.jsx → Total Size: 2.84kB

Files in assets/index-*.js:

  • ./src/components/appointments/cancel/CancelAppointment.jsx → Total Size: 5.47kB

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.85%. Comparing base (8548829) to head (db08f20).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #787      +/-   ##
==========================================
- Coverage   83.86%   83.85%   -0.01%     
==========================================
  Files         245      245              
  Lines        4808     4807       -1     
  Branches     1279     1271       -8     
==========================================
- Hits         4032     4031       -1     
  Misses        747      747              
  Partials       29       29              
Flag Coverage Δ
storybook 77.44% <100.00%> (-0.01%) ⬇️
vitest 62.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens marked this pull request as draft January 28, 2025 15:56
@vaszig vaszig force-pushed the of-4917/update-buttons-style branch from 9f211a5 to db08f20 Compare February 21, 2025 07:33
@vaszig
Copy link
Contributor Author

vaszig commented Feb 21, 2025

Formstep

image

Summary

image

Mobile

image

@vaszig vaszig marked this pull request as ready for review February 21, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistente links uitgelijnde buttons en flexibele stylingopties voor formulieren
1 participant