Replace pre-commit in the CI

[e10e3]

Because pre-commit only checks edited files, side effects can cause errors to appear in other files and go unnoticed. On the contrary, the CI's role is to guarantee the soundness of the entire codebase; only checking what changed is insufficient.

This PR replaces pre-commit with an explicit call to the linters (in CI only, pre-commit is still available as a hook).

This process discovered previously silent typing errors.
If anything, we lose pre-commit's interface to select file types: the files must now be given as command arguments.

Edit: There is one maintenance downside; because the CI and the local pre-commit file are now disjoint, they could go out of sync.

Closes #1665

[e10e3]

@MaxHalford Do you remember why you added kwargs handling in simulate_qa?

river/river/stream/qa.py

Lines 145 to 146 in 5531ae5

	for i, (x, y, *kwargs) in enumerate(dataset):
	kwargs = kwargs[0] if kwargs else None

I'm a bit puzzled by it, no dataset from River yields any additional argument.

[MaxHalford]

Hey 👋

I believe it was for progressive validation... But I'd need to check deeper. Do tests pass if you remove it?

[e10e3]

I may have found why: some datasets like MovieLens100K have an optional parameter to unpack attributes.

river/river/datasets/movielens100k.py

Lines 52 to 56 in 5531ae5

	if self.unpack_user_and_item:
	for x, y in X_y:
	user = x.pop("user")
	item = x.pop("item")
	yield x, y, {"user": user, "item": item}

As you wrote in an example, this mechanism is used by recommender models.

All good then.

[e10e3]

It looks like the tests timed out while fetching a remote dataset. I didn't touch that!

[MaxHalford]

Indeed, it was for the user_id and item_id fields in the recsys models. Good catch!

[e10e3]

There is a maintenance downside to this PR: the CI configuration and the pre-commit file could go out of sync because they are not the same file any more.
It may still be worth it, but it's not mine to decide.

Also, the tests are now green, thank you @smastelini for re-running them!