Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: recipe pipelines #1528

Merged
merged 5 commits into from
Apr 22, 2024
Merged

Conversation

FBruzzesi
Copy link
Contributor

@FBruzzesi FBruzzesi commented Apr 19, 2024

Description

As discussed in Misunderstanding in Pipelines Recipe, the current documentation page dedicated to pipelines seems to be a bit out of sync with the current implementation of the class.

This is an attempt to fix that. I know that documentation can be quite opinionated 🙈 I tried to keep the original phrasing whenever I could do so.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@gbolmier gbolmier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for promptly opening this PR and putting your time in it @FBruzzesi 🙌

I answered your comments and left some of my own. Hope it'll help

Copy link
Member

@gbolmier gbolmier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution @FBruzzesi 🙌

@gbolmier gbolmier merged commit 4a93461 into online-ml:main Apr 22, 2024
4 checks passed
@FBruzzesi FBruzzesi deleted the docs/recipe-pipelines branch April 22, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants