[REF] membership changes #80
Conversation
gbrito
force-pushed
the
16.0-membership_group
branch
from
78f11d5 to
937a838
Compare
gbrito
force-pushed
the
16.0-membership_group
branch
3 times, most recently
from
d4a7b44 to
6c40c93
Compare
tarteo
force-pushed
the
16.0-membership_group
branch
from
6c40c93 to
e5b047e
Compare
| <field name="active" eval="True" /> | ||
| </record> | ||
|
|
||
| <record id="ir_cron_revoke_memberships" model="ir.cron"> |
| <field name="date_from" optional="show" /> | ||
| <field name="date_to" optional="show" /> | ||
| <field name="date_end" optional="hide" /> | ||
| <field name="type" optional="hide" /> |
There was a problem hiding this comment.
Please, make this field visible by default
| today = fields.Date.today() | ||
| values = [{"partner_id": member.id, "date": today} for member in voting_members] | ||
| self.search([("date", "=", today)]).sudo().unlink() | ||
| self.sudo().create(values) |
There was a problem hiding this comment.
Can you remove the sudo here and instead use ir.model.access. I think we can give full rights to the user and add delete="false" create="false" on the tree for ux
| date_end = fields.Date( | ||
| help="End date of the membership", | ||
| ) | ||
| can_revoke_membership = fields.Boolean(compute="_compute_can_revoke_membership") |
There was a problem hiding this comment.
I'm not sure what this field is used for atm. Left over for development?
| @api.model | ||
| def action_create_can_vote_snapshot(self): | ||
| voting_members = self.env["res.partner"].search( | ||
| [("member_can_vote", "=", True)] |
There was a problem hiding this comment.
When I have voting members in the future or in the past it doesn't work. Is it maybe easier to have a domain which uses date_from and date_end / date_to on membership.group.member? And then in membership.vote.history.open_at_date set the selected date as context variable.
Or maybe make member_can_vote dependent on context (api.depends_context)
No description provided.