test: initial structure for covering all key scenarios #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gosuto-inzasheru
approved these changes
Aug 26, 2024
| if (!_isModuleEnabled()) revert ModuleNotEnabled(); | ||
|
|
||
| (, uint256 unlockable,,) = AURA_LOCKER.lockedBalances(address(SAFE)); | ||
| if (unlockable == 0) revert NothingToLock(block.timestamp); |
There was a problem hiding this comment.
im guessing formally reverting it will prevent chainlink from making the actual call, and thus saving gas?
|
|
||
| /// @dev The Gnosis Safe version 1.1.1 does not expose directly `isModuleEnabled` method, so we need a workaround | ||
| function _isModuleEnabled() internal view returns (bool) { | ||
| address[] memory modules = SAFE.getModules(); |
There was a problem hiding this comment.
getModules() is limited to the first ten modules in the list, but i think that should be fine for now
| } | ||
|
|
||
| function test_revertWhen_NothingToUnlock() public {} | ||
| function testPerformUpkeep_revertWhen_NothingToLock() public { | ||
| // force a `performUpkeep` when weeks did not go by |
There was a problem hiding this comment.
"when not enough weeks went by"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.