Skip to content

Commit

Permalink
use --aspects=<...> syntax (#18)
Browse files Browse the repository at this point in the history
Update examples and readme to match syntax in
https://bazel.build/reference/command-line-reference#flag--aspects

Change-Id: If7142d3cb033e3c3f083cb72326bd754c7b6b3f2
  • Loading branch information
oliverlee authored Jun 28, 2024
1 parent 7ef1f89 commit b647388
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 15 deletions.
11 changes: 4 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,10 @@ http_repository(

```Starlark
# //:.bazelrc

build:clang-format --aspects @bazel_clang_format//:defs.bzl%check_aspect
build:clang-format --aspects=@bazel_clang_format//:defs.bzl%check_aspect
build:clang-format --output_groups=report

build:clang-format-fix --aspects @bazel_clang_format//:defs.bzl%fix_aspect
build:clang-format-fix --aspects=@bazel_clang_format//:defs.bzl%fix_aspect
build:clang-format-fix --output_groups=report
build:clang-format-fix --use_action_cache=false
```
Expand Down Expand Up @@ -62,13 +61,12 @@ build setting in `.bazelrc`.

```Starlark
# //:.bazelrc

build:clang-format-base --output_groups=report
build:clang-format-base --@bazel_clang_format//:binary=@llvm18//:clang-format

build:clang-format --aspects @bazel_clang_format//:defs.bzl%check_aspect
build:clang-format --aspects=@bazel_clang_format//:defs.bzl%check_aspect

build:clang-format-fix --aspects @bazel_clang_format//:defs.bzl%fix_aspect
build:clang-format-fix --aspects=@bazel_clang_format//:defs.bzl%fix_aspect
build:clang-format-fix --use_action_cache=false
```

Expand All @@ -95,7 +93,6 @@ filegroup(

```Starlark
# //:.bazelrc

build:clang-format-base --output_groups=report
build:clang-format-base --@bazel_clang_format//:config=//:clang-format-config
...
Expand Down
4 changes: 2 additions & 2 deletions example/default/.bazelrc
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
common --enable_bzlmod=false

build:clang-format --aspects @bazel_clang_format//:defs.bzl%check_aspect
build:clang-format --aspects=@bazel_clang_format//:defs.bzl%check_aspect
build:clang-format --output_groups=report

build:clang-format-fix --aspects @bazel_clang_format//:defs.bzl%fix_aspect
build:clang-format-fix --aspects=@bazel_clang_format//:defs.bzl%fix_aspect
build:clang-format-fix --output_groups=report
build:clang-format-fix --use_action_cache=false
4 changes: 2 additions & 2 deletions example/format-binary/.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ build:clang-format-base --output_groups=report
build:clang-format-base --keep_going

build:clang-format --config=clang-format-base
build:clang-format --aspects @bazel_clang_format//:defs.bzl%check_aspect
build:clang-format --aspects=@bazel_clang_format//:defs.bzl%check_aspect

build:clang-format-fix --config=clang-format-base
build:clang-format-fix --aspects @bazel_clang_format//:defs.bzl%fix_aspect
build:clang-format-fix --aspects=@bazel_clang_format//:defs.bzl%fix_aspect
build:clang-format-fix --use_action_cache=false
4 changes: 2 additions & 2 deletions example/format-config/.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ build:clang-format-base --output_groups=report
build:clang-format-base --keep_going

build:clang-format --config=clang-format-base
build:clang-format --aspects @bazel_clang_format//:defs.bzl%check_aspect
build:clang-format --aspects=@bazel_clang_format//:defs.bzl%check_aspect

build:clang-format-fix --config=clang-format-base
build:clang-format-fix --aspects @bazel_clang_format//:defs.bzl%fix_aspect
build:clang-format-fix --aspects=@bazel_clang_format//:defs.bzl%fix_aspect
build:clang-format-fix --use_action_cache=false
4 changes: 2 additions & 2 deletions example/format-ignore/.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ build:clang-format-base --output_groups=report
build:clang-format-base --keep_going

build:clang-format --config=clang-format-base
build:clang-format --aspects @bazel_clang_format//:defs.bzl%check_aspect
build:clang-format --aspects=@bazel_clang_format//:defs.bzl%check_aspect

build:clang-format-fix --config=clang-format-base
build:clang-format-fix --aspects @bazel_clang_format//:defs.bzl%fix_aspect
build:clang-format-fix --aspects=@bazel_clang_format//:defs.bzl%fix_aspect
build:clang-format-fix --use_action_cache=false

0 comments on commit b647388

Please sign in to comment.