Intel/CI: Add OneCCL CPU tests with DSA + shm to the CI #9904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachdworkin
requested changes
Mar 18, 2024
|
Wait until the 'v1.21.x' branch is created. |
|
The v1.21.x branch has been created. |
zachdworkin
approved these changes
Mar 19, 2024
- Add OneCCL DSA stage. - There was an issue with libfabric being built with ze and oneccl built without. This led to failure and CCL transport being switched to MPI because oneccl looked for the library. To avoid this, an else case is added with --with-ze=no. Signed-off-by: Juee Himalbhai Desai <juee.himalbhai.desai@intel.com>
Juee14Desai
force-pushed
the
main
branch
4 times, most recently
from
05b79cc to
c736ec8
Compare
- Update oneccl summarizer to support DSA + shm summary. - Add the logic to check whether DSA was actually used or not. Signed-off-by: Juee Himalbhai Desai <juee.himalbhai.desai@intel.com>
zachdworkin
approved these changes
Mar 20, 2024
|
AWS CI does not need to finish since these changes are only to Intel CI |
This was referenced Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This led to failure and CCL transport being switched to MPI because oneccl looked for the library.
To avoid this, an else case is added with --with-ze=no.