fabtests, contrib/intel/jenkins: Add IO_URING support to CI #9762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new exclude file for io_uring tests is required for runfabtests.sh with FI_TCP_IO_URING=1 enabled because the codepath isn't fully implemented. Adding this exclude file will enable the tests to be added to libfabric CI so that as code gets added the tests can be removed from this exclude file and tested in the CI. Signed-off-by: Zach Dworkin <zachary.dworkin@intel.com>
shefty
reviewed
Jan 24, 2024
| @@ -18,7 +18,7 @@ def __call__(self, parser, namespace, values, option_string=None): | |||
| parser = argparse.ArgumentParser() | |||
| parser.add_argument('--build_hw', help="HW type for build", | |||
| choices=['water', 'grass', 'fire', 'electric', 'daos',\ | |||
| 'gpu', 'ucx']) | |||
| 'gpu', 'ucx', 'ivysaur']) | |||
There was a problem hiding this comment.
The CI naming scheme brings me much joy.
Signed-off-by: Zach Dworkin <zachary.dworkin@intel.com>
zachdworkin
force-pushed
the
cloudbees
branch
from
175d389 to
6eefbe0
Compare
ooststep
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add io_uring.exclude file to pass to runfabtests.sh
The goal of this file add is to allow us to enable IO_URING tests in the CI without having massive failures. This is because the code path for io_uring is not 100% complete but there are still many passing tests that we would like to run the CI on.
The CI changes required for this are adding a new build step to the CI to build and run on a new pair of nodes that have IO_URING support. We need to add the build step, run step, summary setep, and add support for specific hardware selection in the CI.