prov/efa: More fixes for efa-direct #10811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit f3e26d6 introduces another bug that the max_msg_size can be larger than the the max_msg_size of efa_prov_info when FI_RMA is requested: This will cause the fi_endpoint() call failed when comparing the user info and prov info. This patch fixes this issue by making the prov_info always use the largest max_msg_size, and conditionally reduce the returned user_info to the smaller max_msg_size when FI_RMA is not requested. Signed-off-by: Shi Jin <sjina@amazon.com>
shijin-aws
changed the title
shijin-aws
force-pushed
the
max_msg_size
branch
from
26b73e9 to
d853064
Compare
1. efa_ep should support selective_completion after the FI_CONTEXT2 implementation 2. split efa_cntr_open as efa_cntr_open and efa_rdm_cntr_open. efa_rdm_cntr_open is only used for rdm info type. Both of them setup the correct progress function accordingly. We need separate open functions because there is no way to distinguish efa-direct and efa-rdm during the cntr_open call as there is no user_info object Signed-off-by: Shi Jin <sjina@amazon.com>
shijin-aws
force-pushed
the
max_msg_size
branch
from
d853064 to
4e5d894
Compare
sunkuamzn
approved these changes
Feb 21, 2025
| @@ -227,12 +227,6 @@ static int efa_ep_bind(struct fid *fid, struct fid *bfid, uint64_t flags) | |||
|
|
|||
| switch (bfid->fclass) { | |||
| case FI_CLASS_CQ: | |||
| if (flags & FI_SELECTIVE_COMPLETION) { | |||
There was a problem hiding this comment.
Why did we have this in the first place? Because dgram doesn't support FI_SELECTIVE_COMPLETION?
There was a problem hiding this comment.
And the efa_ep PR was merged before the FI_CONTEXT2 change, so I didn't remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A series of fixes for efa-direct:
Tested by #10800 on p5