prov/efa: Fix the clean up issue for efa_util_prov #10807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijin-aws
force-pushed
the
efa_util_prov_cleanup
branch
from
9fe321d to
da3a2fd
Compare
zachdworkin
previously approved these changes
Feb 20, 2025
|
@shijin-aws I am forcing intel ci to run this. The X will go away when our controller picks up the job |
Commit b7b9dd6 makes efa_prov always returned by EFA_INI, even when efa device is not available. Then in `fi_fini` the efa_prov_finialize` will be triggered on non-EFA platform. However, the current efa_prov_finalize doesn't handle the case where the resources were not created, and it will cause a double free error. This patch fixes this issue. Signed-off-by: Shi Jin <sjina@amazon.com>
shijin-aws
force-pushed
the
efa_util_prov_cleanup
branch
from
da3a2fd to
de6479d
Compare
|
bot:aws:retest |
|
@zachdworkin fixed a bug in earlier push, should be good now. |
|
@shijin-aws thanks, our CI passed the second re-run |
jiaxiyan
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit b7b9dd6 makes efa_prov always returned
by EFA_INI, even when efa device is not available. Then in
fi_finithe efa_prov_finialize` will betriggered on non-EFA platform. However, the current efa_prov_finalize doesn't handle the case where
the resources were not created, and it will cause
a double free error.
This patch fixex this issue.