prov/efa: Fix the max_msg_size reporting for efa-direct #10802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, efa-direct always return the max of rdma size and mtu size when device rdma is supported. This is wrong because when FI_RMA is not requested, only send/recv will be used, and the max_msg_size should be returned as the mtu size only. This patch fixes this issue by moving the max_msg_size change to alter_direct_info based on hints->caps. Also adjust and introduces more unit tests. Signed-off-by: Shi Jin <sjina@amazon.com>
sunkuamzn
reviewed
Feb 20, 2025
Signed-off-by: Shi Jin <sjina@amazon.com>
sunkuamzn
approved these changes
Feb 20, 2025
jiaxiyan
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, efa-direct always return the max of rdma size and mtu size when device rdma is supported. This is wrong because when FI_RMA is not requested, only send/recv will be used, and the max_msg_size should be returned as the mtu size only. This patch fixes this issue by moving the max_msg_size change to alter_direct_info based on hints->caps.
Also adjust and introduces more unit tests.