prov/verbs: Always return vrb_prov in VERBS_INI #10795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously NULL was returned if vrb_os_ini() failed. This mainly affected Windows because the function would always succeed on Linux. On Windows, the function would fail if the ND driver failed to initialize. Returning NULL from VEBRS_INI prevents fi_getinfo() from working as expecetd when the FI_PROV_ATTR_ONLY flags is used. This patch moves the vrb_os_ini() check to vrb_init_info() which is invoked when fi_getinfo() is called the first time. Signed-off-by: Jianxin Xiong <jianxin.xiong@intel.com>
shijin-aws
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously NULL was returned if vrb_os_ini() failed. This mainly affected Windows because the function would always succeed on Linux. On Windows, the function would fail if the ND driver failed to initialize.
Returning NULL from VEBRS_INI prevents fi_getinfo() from working as expecetd when the FI_PROV_ATTR_ONLY flags is used. This patch moves the vrb_os_ini() check to vrb_init_info() which is invoked when fi_getinfo() is called the first time.
Similar to #10794