Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved placeholder logic out of Javascript and the DOM and into CSS #6

Merged
merged 14 commits into from
Jun 21, 2013

Conversation

izak
Copy link

@izak izak commented Jun 3, 2013

This should help with cursor navigation and serializing the DOM.

Also, titles should be able to load up with markup in them instead of just text.

Original request here: wysiwhat#45

color: #AAA;
content: attr(placeholder);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this actually work? appears to not be supported anywhere according to https://developer.mozilla.org/en-US/docs/Web/CSS/attr

nvm, is supported in all modern browsers

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this will work with any browser that supports CSS 2.1

@therealmarv
Copy link
Member

looks good for me. Notes working in demos 👍

@TomWoodward
Copy link
Member

i'm still worried but if you guys have tested and it works then 🍰

@therealmarv
Copy link
Member

Do you know how reproduce your error @tmsp1 ?

@TomWoodward
Copy link
Member

definitely still getting mapping error when trying to save documents with notes on testing, what environment are you guys using?

you can see that there are a bunch of classes that should be being stripped off note's title elements that aren't <div class="title aloha-editable aloha-block-blocklevel-sortable ui-sortable" placeholder="Add a title (optional)" id="26c6eb17-0d15-5711-b3ce-170947dc7606">My note title</div> the error i'm getting is just the standard TODO: p/@class

@TomWoodward
Copy link
Member

@therealmarv @philschatz added a few commits to fix mapping errors, another round of review on this would be awesome

TomWoodward added a commit that referenced this pull request Jun 21, 2013
Moved placeholder logic out of Javascript and the DOM and into CSS
@TomWoodward TomWoodward merged commit 215724a into master Jun 21, 2013
@philschatz philschatz deleted the placeholder-in-css branch January 10, 2014 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants