-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved placeholder logic out of Javascript and the DOM and into CSS #6
Conversation
color: #AAA; | ||
content: attr(placeholder); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this actually work? appears to not be supported anywhere according to https://developer.mozilla.org/en-US/docs/Web/CSS/attr
nvm, is supported in all modern browsers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this will work with any browser that supports CSS 2.1
looks good for me. Notes working in demos 👍 |
i'm still worried but if you guys have tested and it works then 🍰 |
Do you know how reproduce your error @tmsp1 ? |
definitely still getting mapping error when trying to save documents with notes on testing, what environment are you guys using? you can see that there are a bunch of classes that should be being stripped off note's title elements that aren't |
@therealmarv @philschatz added a few commits to fix mapping errors, another round of review on this would be awesome |
Moved placeholder logic out of Javascript and the DOM and into CSS
This should help with cursor navigation and serializing the DOM.
Also, titles should be able to load up with markup in them instead of just text.
Original request here: wysiwhat#45