fix: improve importing items using cli and queue. Link translated ite… #2677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Front-end summary Node 18
|
tikhanovichA
requested review from
a team,
bartlomiejmarszal,
KirylHatalski,
pnal,
Karol-Stelmaczonek,
viktar-dzmitryieu-tao and
poyuki
and removed request for
a team
KirylHatalski
approved these changes
Feb 10, 2025
pnal
approved these changes
Feb 13, 2025
| ); | ||
| foreach ($linkedItems as $linkedItem) { | ||
| $translations++; | ||
| if ($this->wetRun) { |
There was a problem hiding this comment.
Suggested change
| if ($this->wetRun) { | |
| if (!$this->wetRun) { | |
| continue; | |
| } |
bartlomiejmarszal
approved these changes
Feb 13, 2025
Version
There are 0 BREAKING CHANGE, 0 feature, 7 fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make sure that all required metadata propagated to main and translated items
so authoring translation solution take it into account as translated versions of language
After migration from the client, we have all items for different languages. We need to link them based on the uniq ID