-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/node: Update client node configuration #1124
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for oasisprotocol-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainnet still has 24.3.2, so we shouldn't update docs until that is at 25.0? Otherwise this is good.
@@ -200,14 +200,22 @@ runtime: | |||
# Paths to ParaTime bundles for all of the supported ParaTimes. | |||
paths: | |||
- {{ runtime_orc_path }} | |||
# Configure ParaTimes to run outside of a Trusted Execution Environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this even needed? If no TEE is specified, it is automatically selected based on availability, with TDX and SGX taking precedence over ELF. If we want to just illustrate how a RONL can be optionally configured, we could show an commented out example? Would it make sense to also show an example of the runtime.runtimes[].config
field?
# config:
# estimate_gas_by_simulating_contracts: true
# allowed_queries:
# - all_expensive: true
@@ -200,14 +200,22 @@ runtime: | |||
# Paths to ParaTime bundles for all of the supported ParaTimes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are ROFL runtimes also called ParaTimes? It might be cleaner if we revision this "ParaTime" naming convention and start using the new more meaningful names, "runtime on-chain logic (RONL) (aka ParaTime/chain)" and "runtime off-chain logic (ROFL)".
No description provided.