Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/node: Update client node configuration #1124

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

peternose
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for oasisprotocol-docs ready!

Name Link
🔨 Latest commit e3db904
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-docs/deploys/67a5e953b3afc1000880a309
😎 Deploy Preview https://deploy-preview-1124--oasisprotocol-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@peternose peternose requested review from kostko and gw0 February 11, 2025 15:18
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainnet still has 24.3.2, so we shouldn't update docs until that is at 25.0? Otherwise this is good.

@@ -200,14 +200,22 @@ runtime:
# Paths to ParaTime bundles for all of the supported ParaTimes.
paths:
- {{ runtime_orc_path }}
# Configure ParaTimes to run outside of a Trusted Execution Environment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this even needed? If no TEE is specified, it is automatically selected based on availability, with TDX and SGX taking precedence over ELF. If we want to just illustrate how a RONL can be optionally configured, we could show an commented out example? Would it make sense to also show an example of the runtime.runtimes[].config field?

# config:
#   estimate_gas_by_simulating_contracts: true
#   allowed_queries:
#     - all_expensive: true

@@ -200,14 +200,22 @@ runtime:
# Paths to ParaTime bundles for all of the supported ParaTimes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are ROFL runtimes also called ParaTimes? It might be cleaner if we revision this "ParaTime" naming convention and start using the new more meaningful names, "runtime on-chain logic (RONL) (aka ParaTime/chain)" and "runtime off-chain logic (ROFL)".

@gw0 gw0 self-requested a review February 13, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants